Comments for Germán Póo-Caamaño

Comment on How many recent files does an application really need? by gpoo

gpoo — Tue, 01 Apr 2008 14:59:01 +0000

Ian,

You should look the patch and discussion given by Mike
(#524896)

Comment on How many recent files does an application really need? by gpoo

gpoo — Tue, 01 Apr 2008 14:45:16 +0000

Björn,

I wasn’t aware about defaultdict. Good to know it, thanks :-)

Comment on How many recent files does an application really need? by gpoo

gpoo — Tue, 01 Apr 2008 14:44:21 +0000

Ian, as was pointed by Emmanuel and Alan, applications like Gimmie couldn’t access the historical data if this is not available.

What about having 2 recently-used files? I mean, recently-used.xbel and recently-used-history.xbel. Both of them below the same GtkRecentManager API. The limit may be hardcoded (25 as you say), good enough for a quick search by the every day use but not losing the historical data.

Comment on How many recent files does an application really need? by Iain

Iain — Tue, 01 Apr 2008 14:20:17 +0000

Cleaning up after applications who are putting entries in this history file is a really bad way of doing it. This would not address the root cause in any way, it would merely hide the problem and create extra complexity.
I believe that the following should be done:

1. Applications should not be responsible for cleaning up after them selves, there should be a default limit (say 25 entries per app) which can be extended if needs be by the application. Effectively if we add a new entry and we have hit our limit the oldest entry gets pushed off the end of the list.

2. do not call the time() system call for every entry in the recently-used file when sorting it, this is really inefficient and I’m fairly certain this is the slowdown people are experiencing.

In short: redesign the recent-manager not create a new bit of code to look after the mess it creates!

Comment on How many recent files does an application really need? by björn

björn — Tue, 01 Apr 2008 13:19:49 +0000

You’ll save a few lines by using defaultdict

Comment on How many recent files does an application really need? by Mike

Mike — Tue, 01 Apr 2008 12:27:41 +0000

I proposed an automatic cleaner at http://bugzilla.gnome.org/show_bug.cgi?id=524896. It limits the items by age, imposes a maximum number per mime type, and deletes non-existent ones.

Comment on How many recent files does an application really need? by Iain

Iain — Tue, 01 Apr 2008 11:44:32 +0000

I also have been looking into this and the issue isn’t really with eog its with ‘gtk recent manager’, and interestingly I blogged about this only yesterday read more here: http://blog.buttermountain.co.uk/2008/03/31/high-cpu-usage-from-eog-gnome-panel-blame-gtks-recent-manager/

It really needs to be fixed.

Comment on How many recent files does an application really need? by Alan

Alan — Tue, 01 Apr 2008 09:12:55 +0000

Well ideally the old Recent items would overly into a History list rather than falling into a useless limbo.

Comment on How many recent files does an application really need? by Uzytkownik

Uzytkownik — Tue, 01 Apr 2008 08:43:24 +0000

At least in 2.22.x Gnome (i.e. in 2.x.y gtk+) you can enter it by GtkFileChooserDialog.

Comment on How many recent files does an application really need? by Emmanuele Bassi

Emmanuele Bassi — Tue, 01 Apr 2008 08:31:31 +0000

instead of using the session start, this should be invoked with the session ending, to avoid cluttering up an already slow start up sequence.

also, see my blog for what is missing from gtk+ and why.